Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in declaring size of compressed dict page. #72

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

jorgecarleitao
Copy link
Owner

No description provided.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Dec 9, 2021
@jorgecarleitao
Copy link
Owner Author

Thanks to @mhconradt and @ritchie46 for the initial report here: pola-rs/polars#2009

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #72 (7e5b059) into main (adbd7cd) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   69.38%   69.35%   -0.04%     
==========================================
  Files          66       66              
  Lines        3685     3687       +2     
==========================================
  Hits         2557     2557              
- Misses       1128     1130       +2     
Impacted Files Coverage Δ
src/page/page_dict/mod.rs 78.94% <0.00%> (ø)
src/write/compression.rs 0.00% <0.00%> (ø)
src/write/page.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbd7cd...7e5b059. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants